I updated few routines to correct few things:
- Fixed a problem with incremental 4DVar (IS4DVAR) that forced the inner loop to converge after two iterations of the inner loop regardless of the values used for the convergence of the total cost function, CostFunFac. This parameter is set in s4dvar.in and represents the percentage of total cost function change between successive iterations in the inner loop. The comparison between old and new values was wrong. Many thanks to Javier and Brian for noticing this.
- Corrected the fifth argument call for routine get_state for several drivers. Now a dummy variable is used instead of a numerical value. This variable has the intent(inout) declaration in get_state. This problem was giving us segmentation violation in a cluster using MPI. Many thanks to Brian for finding this one.