Opened 13 years ago

Closed 13 years ago

#62 closed bug (Done)

Reference to NETCDF_INCDIR no longer required in CPPFLAGS

Reported by: m.hadfield Owned by: arango
Priority: minor Milestone: Release ROMS/TOMS 3.1
Component: Nonlinear Version: 3.1
Keywords: Cc:

Description

The platform-specific make files all contain the following

         CPPFLAGS += -I$(NETCDF_INCDIR)

This is a relic of the days when the netCDF F77 definitions were imported via an include statement in mod_netcdf.F

#include "netcdf.inc"

This is unnecessary now that the netCDF F90 interface is imported via a USE statement. The only place where NETCDF_INCDIR is required now is in the master makefile:

$(SCRATCH_DIR)/$(NETCDF_MODFILE): | $(SCRATCH_DIR)
	cp -f $(NETCDF_INCDIR)/$(NETCDF_MODFILE) $(SCRATCH_DIR)

$(SCRATCH_DIR)/$(TYPESIZES_MODFILE): | $(SCRATCH_DIR)
	cp -f $(NETCDF_INCDIR)/$(TYPESIZES_MODFILE) $(SCRATCH_DIR)

Change History (2)

comment:1 Changed 13 years ago by m.hadfield

So what I'm suggesting is that the unnecessary line be removed.

comment:2 Changed 13 years ago by arango

  • Resolution set to Done
  • Status changed from new to closed

Done. I added the few comments to the PGI configuration files. I added a commented option to enforce IEEE floating-point operations. This allows to produce identical solutions with all an new version of the PGI compiler.

Note: See TracTickets for help on using tickets.