Opened 15 years ago
Closed 15 years ago
#340 closed bug (Fixed)
Corrected bug in quadratic bottom stress for ice cavitiies
| Reported by: | arango | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.3 |
| Component: | Nonlinear | Version: | 3.3 |
| Keywords: | Cc: |
Description
Corrected a bug in set_vbc.F when computing the quadratic bottom stress for ice cavities (ICESHELF and UV_QDRAG). Around line 353 we need
cff2=SQRT(u(i,j,N(ng),nrhs)*u(i,j,N(ng),nrhs)+cff1*cff1)
instead. Many thanks to Ben Galton-Fensi and Michael Dinniman for reporting this bug.
Also corrected couple of typos in set_scoord.F when reporting vertical stretching values to standard output. Many thanks to John Luick for bringing this issue to my attention.
Change History (3)
comment:1 by , 15 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 15 years ago
| Resolution: | Fixed |
|---|---|
| Status: | closed → reopened |
comment:3 by , 15 years ago
| Resolution: | → Fixed |
|---|---|
| Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.
I didn't got the change to set_scoord.F correctly, hmim should be changed to hmin (line 454) and there is a missing continuation character in line 455. Many thanks to Brian Powell for bringing this to my attention.
cff1=hmin(ng)*(SCALARS(ng)%sc_w(k)*hc(ng)+ & & SCALARS(ng)%Cs_w(k)*hmin(ng))/ & & (hc(ng)+hmin(ng))