Opened 15 years ago

Closed 15 years ago

#339 closed bug (Fixed)

Incorrect logic in get_ngfld

Reported by: arango Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.3
Component: Nonlinear Version: 3.3
Keywords: Cc:

Description (last modified by arango)

Warning: This is a very important fix when your input files are not CF compliant. Recall that get_ngfld is used to process boundary, river, and tide data.

Corrected a bug in file get_ngfld.F around line 193. We need to use n_vdim instead of n_dim in the DO loop:

!
!  If Nrec=0, input file is not CF compliant, check variable dimension
!  to see if the dimension contains the "time" string.
!
            IF (got_time.and.(Nrec.eq.0)) THEN
              DO i=1,n_vdim
                IF (INDEX(TRIM(var_Dname(i)),'time').ne.0) THEN
                  Nrec=var_Dsize(i)
                END IF
              END DO
            END IF

This only occurs when input file is not CF compliant with the time dimension. In the previous versions you will get an out of bounds error for variable var_Dname.

I also updated several of the CDL files to be CF compliant.

Change History (1)

comment:1 by arango, 15 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.