Opened 3 weeks ago
Closed 3 weeks ago
#986 closed upgrade (Done)
VERY IMPORTANT: Adding the Estuarine Carbon Biogeochemical Model
Reported by: | arango | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 4.3 |
Component: | Nonlinear | Version: | 4.3 |
Keywords: | Cc: |
Description (last modified by )
This PR adds a new model to the ROMS suite of ecosystem kernels. The Estuarine Carbon Biogeochemical (ECB) model was developed by colleagues (Feng et al., 2015, and follow-ups) at the Virginia Institute of Marine Science (VIMS), William & Mary.
For more information, please check:
https://github.com/myroms/roms/pull/61
It is currently in the feature/ecb branch until colleagues at VIMS review and test it before merging to the develop branch.
Change History (5)
comment:1 by , 3 weeks ago
Description: | modified (diff) |
---|
comment:2 by , 3 weeks ago
Resolution: | → WillNotFix |
---|---|
Status: | new → closed |
comment:3 by , 3 weeks ago
I pushed the wrong button when closing the ticket. It says it WillNotFix instead of Done.
comment:4 by , 3 weeks ago
Description: | modified (diff) |
---|---|
Resolution: | WillNotFix |
Status: | closed → reopened |
comment:5 by , 3 weeks ago
Resolution: | → Done |
---|---|
Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.
Many thanks to Pierre St-Laurent for testing and correcting the feature/ECB branch implementation.
Congratulations to the VIMS team for coding the ECB model. It is well documented in the literature, and the papers are clear, well-written, and easy to follow.
The code is also well-written and thoroughly documented. I appreciate that all the contributors follow our standard in ROMS when adding a generic ecosystem kernel.