Opened 4 years ago

Closed 4 years ago

#906 closed bug (Fixed)

IMPORTANT: Corrected structure syntax in equilibrium_tide.F

Reported by: arango Owned by:
Priority: major Milestone: Release ROMS/TOMS 4.0
Component: Nonlinear Version: 3.9
Keywords: Cc:

Description

The structures in equilibrium_tide.F were using . (dot, Matlab style) instead of % (percent for Fortran) in several places. We tested this algorithm in Matlab and missed changing the syntax when coding in Fortran. The weird think is that the ifort compiler accepts such syntax. It is scary!

For example, we need to have: 

     Q1%Afl=Q1%amp*Q1%f*Q1%love
     O1%Afl=O1%amp*O1%f*O1%love
     K1%Afl=K1%amp*K1%f*K1%love
     N2%Afl=N2%amp*N2%f*N2%love
     M2%Afl=M2%amp*M2%f*M2%love
     S2%Afl=S2%amp*S2%f*S2%love
     K2%Afl=K2%amp*K2%f*K2%love

instead of 

     Q1.Afl=Q1.amp*Q1.f*Q1.love
     O1.Afl=O1.amp*O1.f*O1.love
     K1.Afl=K1.amp*K1.f*K1.love
     N2.Afl=N2.amp*N2.f*N2.love
     M2.Afl=M2.amp*M2.f*M2.love
     S2.Afl=S2.amp*S2.f*S2.love
     K2.Afl=K2.amp*K2.f*K2.love

Many thanks to Brian Powell and Guangpang Liu for reporting this bug.

Change History (1)

comment:1 by arango, 4 years ago

Resolution: → Fixed
Status: new → closed
Note: See TracTickets for help on using tickets.