Opened 4 years ago

Closed 4 years ago

#863 closed upgrade (Done)

Size of characters in mod_netcdf.F

Reported by: arango Owned by:
Priority: major Milestone: Release ROMS/TOMS 3.9
Component: Nonlinear Version: 3.9
Keywords: Cc:

Description (last modified by arango)

I came across with a NetCDF file that has an 80-characters long attribute name:

Analysis_or_forecast_generating_process_identifier_defined_by_originating_centre = "MESO NAM Model (currently 12 km)"

It seems that it was impossible to summarize the definition into a shorter attribute name. There must be a law against such violation of programming style and metadata design.

The previous limit of the generic size of dimensions, variable, and attribute names was 40. It is now increased to 100:

!
      character (len=100) :: att_name(Matts)     ! attribute names
      character (len=100) :: dim_name(Mdims)     ! dimension names
      character (len=100) :: var_name(Mvars)     ! variable names
!
!  Generic information about requested current variable.
!
      integer :: n_vdim                 ! number of variable dimensions
      integer :: n_vatt                 ! number of variable attributes
      integer :: var_kind               ! external data type
      integer :: var_Dids(NvarD)        ! dimensions ID
      integer :: var_Dsize(NvarD)       ! dimensions values
      integer :: var_Aint(NvarA)        ! attribute integer values
      real(r8) :: var_Afloat(NvarA)     ! attribute float values
!
      character (len=100)  :: var_Aname(NvarA)   ! Attribute names
      character (len=100)  :: var_Dname(NvarD)   ! dimension names
      character (len=1024) :: var_Achar(NvarA)   ! Attribute char values

Change History (1)

comment:1 by arango, 4 years ago

Description: modified (diff)
Resolution: Done
Status: newclosed
Type: bugupgrade
Note: See TracTickets for help on using tickets.