Opened 5 years ago
Closed 5 years ago
#847 closed bug (Fixed)
VERY IMPORTANT: Corrected issues with 4D-Var weak constraint
| Reported by: | arango | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.9 |
| Component: | Adjoint | Version: | 3.9 |
| Keywords: | Cc: |
Description
Fixed couple of issues in the weak constraint 4D-Var algorithm:
- Removed some legacy code in routines forcing.F and tl_forcing.F when processing the impulse forcing for the weak constraint 4D-Var formulation. The legacy code that included the forcing for ubar and vbar in 3D solutions were removed from forcing.F when SOLVE3D is activated. Similarly, the forcing for tl_ubar and tl_vbar was removed from tl_forcing.F.
- Added logic to def_impulse.F, get_data.F, set_data.F, tl_get_data.F, tl_set_data.F, and checkvars.F to avoid processing the weak constraint impulse forcing for ubar (tl_ubar) and vbar (tl_vbar) when SOLVE3D is activated.
Many thanks to Andy Moore for his help in tracking this bug.
Note:
See TracTickets
for help on using tickets.
