Opened 4 years ago

Closed 4 years ago

#836 closed bug (Fixed)

Small Corrections

Reported by: arango Owned by:
Priority: major Milestone: Release ROMS/TOMS 3.8
Component: Nonlinear Version: 3.8
Keywords: Cc:

Description

  • Added missing Ngrids argument to load_s1d call in read_asspar.F:
    #if defined W4DPSAS_FCT_SENSITIVITY && defined OBS_SPACE
                CASE ('OIFnameA')
                  label='OIFA - observartion impacts forecast, analysis'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, OIFA)
                CASE ('OIFnameB')
                  label='OIFB - observartion impacts forecast, background'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, OIFB)
    #endif
    
    Many thanks to Andy Moore and Patrik Drake for reporting this bug.
  • Added missing Ngrids argument to load_s1d call in read_phypar.F:
    #ifdef W4DPSAS_FCT_SENSITIVITY
    # ifndef OBS_SPACE
                CASE ('FOInameA')
                  label='FOIA - adjoint sensitivity functional A'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, FOIA)
                CASE ('FOInameB')
                  label='FOIB - adjoint sensitivity functional B'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, FOIB)
    # endif
                CASE ('FCTnameA')
                  label='FCTA - forecast state forward trajectory A'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, FCTA)
                CASE ('FCTnameB')
                  label='FCTB - forecast state forward trajectory B'
                  Npts=load_s1d(Nval, Cval, Cdim, line, label, igrid,       &
         &                      Ngrids, Nfiles, FCTB)
    #endif
    
    Many thanks to Andy Moore and Patrik Drake for reporting this bug.
  • Added missing declaration for ENDtime and NEXTtime in ntimestep.F:
    #if defined MODEL_COUPLING && !defined MCT_LIB
    !
          real(dp) :: ENDtime, NEXTtime
    #endif
    
  • Corrected information in build_wrf.bash and build_wrf.sh scripts.

Change History (1)

comment:1 by arango, 4 years ago

Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.