Opened 18 years ago
Closed 18 years ago
#74 closed defect (Fixed)
TS_MPDATA, tl_Hz compiling problem
Reported by: | mathieu | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Adjoint Based Algorithms |
Component: | Adjoint | Version: | 3.1 |
Keywords: | Cc: |
Description (last modified by )
In the function ad_pre_step3d.F the variable tl_Hz is used one time but not declared.
I would presume that it has been forgottent to comment it out.
Change History (1)
comment:1 by , 18 years ago
Component: | Nonlinear → Adjoint |
---|---|
Description: | modified (diff) |
Resolution: | → Fixed |
Status: | new → closed |
Summary: | tl_Hz compiling problem → TS_MPDATA, tl_Hz compiling problem |
Type: | bug → defect |
Note:
See TracTickets
for help on using tickets.
No, that's not it. The tl_Hz here needs to be changed to ad_Hz.
The TS_MPDATA is partially coded and untested. We have not coded the tangent linear and adjoint versions of mpdata_adiff routine. We had rewritten the MPDATA algorithm in ROMS several times because we were not fully satisfied with its implementation. So there is not point to build a tangent linear and adjoint codes of an algorithm that is still under testing. It is a wait of time.
The tangent linear and adjoint linearization of the MPDATA algorithm is not trivial. MPDATA, as implemented, is highly nonlinear and we don't know if the tangent linear approximation will hold. The adjoint is a sensitivity operator and it is likely that the TLM, RPM, and ADM will go unstable.
Therefore, we currently do not support the tangent linear, representer, and adjoint for this option.