Opened 18 years ago
Closed 18 years ago
#72 closed defect (Postponed)
CELERITY_*, FORWARD_* and boundary variables.
Reported by: | mathieu | Owned by: | arango |
---|---|---|---|
Priority: | minor | Milestone: | Adjoint Based Algorithms |
Component: | Adjoint | Version: | 3.1 |
Keywords: | Cc: |
Description
It is less a precise bug than a whole array of issues.
Option CELERITY_READ has the following properties:
- It is not documented in cppdefs.h but it is not switched in globaldefs.h. I consider this to be a problem as in my mind it should be one and the other.
- It occurs in checkdefs.F with the option FORWARD_READ but not in any other place. I suspect that this is a false dependency and that CELERITY_READ should be removed from line 522 in this line.
- Appart from above dependency CELERITY_READ occurs always in conjuction with CELERITY_WRITE.
Option FORWARD_WRITE occurs in:
- setting up boundary values with CELERITY_WRITE
BOUNDARY(ng)%zeta_north ...
- in doing write ups of data but not of BOUNDARY(ng) data. So either
- remove the above dependency
- add code for output of boundary data
Proposed solution:
- Remove CELERITY_WRITE from cppdefs.h
- Rename CELERITY_READ and CELERITY_WRITE to CELERITY.
- Trigger CELERITY in globaldefs.h from FORWARD_WRITE if needed.
- Trigger CELERITY in globaldefs.h if EAST_TRADIATION, EAST_FSRADIATION, EAST_M2RADIATION, EAST_M3RADIATION and the same for north, south, west.
Note:
See TracTickets
for help on using tickets.
This option is still no available. It is kind of complicated because we need to save the radiation trajectory at every single time step. A lot of I/O is needed. We make look at this problem in the future.