Opened 7 years ago
Closed 7 years ago
#716 closed defect (Fixed)
Updated def_info.F and mod_scalars.F
| Reported by: | arango | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
| Component: | Nonlinear | Version: | 3.7 |
| Keywords: | Cc: |
Description
Some users are having issues with the FRCNAME global attribute in output NetCDF files because the list of files can be longer than the allocated length size for the string variable in def_info.F. This is solved by changing the length from 1024 to 1048.
character (len=4096) :: string
Many thanks to Dezhou Yang, Kate Hedstrom and Kaitlin Alexander for reporting this issue.
Also, updated mod_scalars.F to initialize the logical switches LdefQCK(ng) and LwrtQCK(ng) asociated the the Quicksave output NetCDF file. This caused random crash behavior when running with lots of processors if the Quicksave output is off. This problem is typical with un-initialized variables and multiple processors. Such logical variables should be initialized to .FALSE. by the compiler, but sometimes it does not. It is always a good strategy to initialize all the variables in a Fortran program! I missed those.
Many thanks to Kaitlin Alexander for reporting this problem.
