Opened 5 years ago

Closed 5 years ago

#673 closed bug (Fixed)

DOGBONE NetCDF contact files and the header file

Reported by: jcwarner Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description (last modified by arango)

For the DOGBONE test case there are 2 issues:

1) the header file dogbone.h has

# define TS_U3HADVECTION"
# define TS_C4VADVECTION"

and this should be changed to (need to remove double quotes at the end)

# define TS_U3HADVECTION
# define TS_C4VADVECTION

2) The NetCDF contact file for the DOGBONE example seems corrupt. I generated this newer version using:

Gnames={'dogbone_grd_whole.nc','dogbone_grd_href3.nc'}

[S,G]=contact(Gnames,'dogbone_contact_refined.nc')

I am attaching the dogbone_contact_refined.nc. This worked for me. It needs to replace the dogbone_ngc_refined.nc.

Change History (1)

comment:1 Changed 5 years ago by arango

  • Description modified (diff)
  • Resolution set to Fixed
  • Status changed from new to closed
  • Summary changed from dogbone netcdf contact and the .h file to DOGBONE NetCDF contact files and the header file

Indeed, thank you. I always use the header file in the test repository and I missed checking this one in the source code repository. I forgot to update the contact points NetCDF files. I computed those with my latest version of contact.m since you forgot to attach the NetCDF files and I don't want them corrupted anyway.

I also update the contact files for DOGBONE in the test repository.

Note: See TracTickets for help on using tickets.