Opened 9 years ago

Closed 9 years ago

#666 closed bug (Fixed)

west sum for nesting not defined

Reported by: jcwarner Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description (last modified by arango)

I thought we had taken care of this, but it is not corrected in the main repository. This is only for the error checking, and will not change results since this is the diagnostic quantities for debugging mass and volume conservation. But can you update this for nesting.F:

  • Line 754 needs to change from
                EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
to
                EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
  • Line 767 needs to change from
                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/WestSum
to
                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/EastSum
  • Line 817 needs to change from
               IF (EastSum.ne.0) THEN
to
               IF (SouthSum.ne.0) THEN
  • Line 859 needs to change from
               m=BRY_CONTACT(isouth,cr)%C2Bindex(Ibf)    ! pick last one
to
               m=BRY_CONTACT(inorth,cr)%C2Bindex(Ibf)    ! pick last one

  • Line 869-870 need to change from
              IF (EastSum.ne.0) THEN
                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/SouthSum
to
              IF (NorthSum.ne.0) THEN
                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/NorthSum

Change History (1)

comment:1 by arango, 9 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed

Indeed, I don't know what happened here. There were couple of typos that you missed. It was correct in my research version. I guess I only corrected my research version and I didn't correct the repositories. As you mentioned, these typos does not affect the nesting solutions since these quantities are only used to check mass and volume conservation at the contact regions during debugging.

Also thanks to John Wilkin for also reporting the same problem.

Note: See TracTickets for help on using tickets.