Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#665 closed bug (Fixed)

Improvements to fennel.h — at Version 2

Reported by: m.hadfield Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description (last modified by arango)

Attached is a lightly modified version of fennel.h with the following improvements, mostly minor, but a significant bug fix:

  1. Added implicit none.
  1. Simplified declaration of u10squ.
  1. Simplified treatment of N & C remineralization fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)
  1. The bug fix: defined a factor fiter = 1/BioIter(ng), applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when BioIter(ng) exceeds 1. I have checked this one out pretty thoroughly!

Change History (3)

by m.hadfield, 10 years ago

Attachment: fennel.h​ added

Corrected version of fennel.h

comment:1 by arango, 10 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Yes, indeed. Good catch correcting this factor in the diagnostic terms. Also thank you for cleaning the code a little.

comment:2 by arango, 10 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.