Opened 11 years ago
Last modified 10 years ago
#649 closed bug
MPDATA tiling bug — at Initial Version
Reported by: | jcwarner | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
Component: | Nonlinear | Version: | 3.7 |
Keywords: | Cc: |
Description
TS_MPDATA developed a tiling bug in the mpdata_adiff.F routine when all the ranges were recoded to be more general. There were only afew places, but it was critical. I found the offending lines and provided a routine (attached) with correct ranges.
Also, i added a new flag TS_MPDATA_LIMIT When this option is activated, the upwind corrector fluxes are further limited to be a factor of 0.25 times the computed corrector flux. We have found that in some limited applications with rapidly varying topography and strong tracer gradients, that the upwind flux was creating some oscillations. This limits that behavior. Of course, if you set the fac to = 0.0, then the method is purely upwind.
-john
mpdata_adiff corrected ranges