Opened 9 years ago

Closed 9 years ago

#649 closed bug (Fixed)

MPDATA tiling bug

Reported by: jcwarner Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description (last modified by arango)

TS_MPDATA developed a tiling bug in the mpdata_adiff.F routine when all the ranges were recoded to be more general. There were only a few places, but it was critical. I found the offending lines and provided a routine (attached) with correct ranges.

Also, i added a new flag TS_MPDATA_LIMIT. When this option is activated, the upwind corrector fluxes are further limited to be a factor of fac = 0.25 times the computed corrector flux. We have found that in some limited applications with rapidly varying topography and strong tracer gradients, that the upwind flux was creating some oscillations. This limits that behavior. Of course, if you set the fac = 1.0, then the method is purely upwind.

Attachments (1)

mpdata_adiff.F​ (52.4 KB ) - added by jcwarner 9 years ago.
mpdata_adiff corrected ranges

Download all attachments as: .zip

Change History (2)

by jcwarner, 9 years ago

Attachment: mpdata_adiff.F​ added

mpdata_adiff corrected ranges

comment:1 by arango, 9 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Thank you for correcting this routine.

Note: See TracTickets for help on using tickets.