Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#642 closed bug (Fixed)

Corrected bug in get_nudcoef.F and def_rst.F

Reported by: arango Owned by: arango
Priority: minor Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description

Corrected couple of bugs:

  • get_nudgcoef.F: Corrected index idM3nc when cheching fro 3D momenutum nudging coefficients.
         IF (LnudgeM3CLM(ng)) THEN
           IF (.not.find_string(var_name,n_var,Vname(1,idM3nc),            &
        &                       NUD(ng)%Vid(idM3nc))) THEN
             IF (Master) WRITE (stdout,10) TRIM(Vname(1,idM3nc)),          &
        &                                  TRIM(ncname)
             exit_flag=2
             RETURN
           END IF
         END IF
    
    Many thank to Ryan Holmes for reporting this typo.
  • def_rst.F: Corrected the output dimension for wetting and drying variables wetdry_mask_u and wetdry_mask_v. We need to have instead:
    !
    !  Define wet/dry mask on U-points.
    !
            Vinfo( 1)=Vname(1,idUwet)
            Vinfo( 2)=Vname(2,idUwet)
            Vinfo( 3)=Vname(3,idUwet)
            Vinfo( 9)='land'
            Vinfo(10)='water'
            Vinfo(14)=Vname(4,idUwet)
            Vinfo(16)=Vname(1,idtime)
            Vinfo(22)='coordinates'
            Aval(5)=REAL(Iinfo(1,idUwet,ng),r8)
            status=def_var(ng, iNLM, RST(ng)%ncid, RST(ng)%Vid(idUwet),     &
         &                 NF_FOUT, nvd3, su2dgrd, Aval, Vinfo, ncname,     &
         &                 SetFillVal = .FALSE.)
            IF (exit_flag.ne.NoError) RETURN
    !
    !  Define wet/dry mask on V-points.
    !
            Vinfo( 1)=Vname(1,idVwet)
            Vinfo( 2)=Vname(2,idVwet)
            Vinfo( 3)=Vname(3,idVwet)
            Vinfo(14)=Vname(4,idVwet)
            Vinfo(16)=Vname(1,idtime)
            Vinfo( 9)='land'
            Vinfo(10)='water'
            Vinfo(22)='coordinates'
            Aval(5)=REAL(Iinfo(1,idVwet,ng),r8)
            status=def_var(ng, iNLM, RST(ng)%ncid, RST(ng)%Vid(idVwet),     &
         &                 NF_FOUT, nvd3, sv2dgrd, Aval, Vinfo, ncname,     &
         &                 SetFillVal = .FALSE.)
            IF (exit_flag.ne.NoError) RETURN
    
    
    Many thanks to Lyon Lanerolle for bringing this to my attention.

Change History (2)

comment:1 by arango, 10 years ago

Resolution: Fixed
Status: newclosed

comment:2 by arango, 10 years ago

Summary: Corrected bug in get_nudcoef.F nad def_rst.FCorrected bug in get_nudcoef.F and def_rst.F
Note: See TracTickets for help on using tickets.