Corrected potential density availability

[arango]

The potential density is computed always now it is and not subject to CPP options. In the equation of state, rho_eos.F, we used to have:

        DO k=1,N(ng)
          DO i=IstrT,IendT
            rho(i,j,k)=den(i,k)
#  if defined LMD_SKPP || defined LMD_BKPP || defined DIAGNOSTICS
            pden(i,j,k)=(den1(i,k)-1000.0_r8)
#   ifdef MASKING
            pden(i,j,k)=pden(i,j,k)*rmask(i,j)
#   endif
#  endif
          END DO
        END DO

The conditional CPP statement used to compute pden is now removed. This will fix the weird values that some users were getting for potential vorticity when none of the above CPP were activated. Many thanks to Deepak Cherian for ​bringing this to my attention.

The obs_provenance variable was missing from the metadata file varinfo.dat. This explains the segmentation violation that some of you where getting when using the 4D-Var algorithm. I was able to reproduce this behavior when updated to a new compiler version. It is amazing what some compilers assume internally nowadays.

I also corrected some formatted statements for standard output. The recommended relationship between field width W and the number of fractional digits D in the format descriptor is W>=D+7. I was using D+6 for positive number (which is correct). Anyway, this change removes all compiling warnings.