Opened 11 years ago

Closed 11 years ago

#601 closed bug (Fixed)

Corrected bug in obs_sen_is4dvar.h

Reported by: arango Owned by: arango
Priority: major Milestone: Adjoint Based Algorithms
Component: Adjoint Version: 3.7
Keywords: Cc:

Description (last modified by arango)

Several indices were not initialized in obs_sen_is4dvar.h when activating IS4DVAR_SENSITIVITY. We need to add:

      DO ng=1,Ngrids
#if defined ADJUST_BOUNDARY || defined ADJUST_STFLUX || \
    defined ADJUST_WSTRESS
        Lfinp(ng)=1         ! forcing index for input
        Lfout(ng)=1         ! forcing index for output history files
#endif
#ifdef ADJUST_BOUNDARY
        Lbinp(ng)=1         ! boundary index for input
        Lbout(ng)=1         ! boundary index for output history files
#endif
        ...
      END DO

We also need to turn off !readNLmod in obs_read.F when IS4DVAR_SENSITIVITY is activated:

# if defined TLM_OBS
#  if defined IS4DVAR_SENSITIVITY
        readNLmod=.FALSE.
#  else
        readNLmod=.TRUE.
#  endif
        readTLmod=.TRUE.
# else
        readNLmod=.FALSE.
        readTLmod=.FALSE.
# endif

Many thanks to Andy Moore and the 4D-Var training class for bringing this to my attention.

Change History (1)

comment:1 by arango, 11 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.