Opened 12 years ago
Closed 12 years ago
#579 closed bug (Fixed)
Corrected logic about tl_LBC
Reported by: | arango | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Adjoint Based Algorithms |
Component: | Nonlinear | Version: | 3.6 |
Keywords: | Cc: |
Description
Moved the computation of the tl_LBC logical switches from read_phypar.F to inp_par.F to allow the processing of biology and sediment tracers. We need to delay the initialization of these switches because read_BioPar or read_SedPar needs to be called first. In inp_par.F we now have:
#if defined TANGENT || defined TL_IOMS ! ! Set lateral boundary condition switches for the tangent linear ! models (TLM and RPM) to the same values as the adjoint model. ! DO ivar=1,nLBCvar DO i=1,4 tl_LBC(i,ivar,ng)%acquire =ad_LBC(i,ivar,ng)%acquire tl_LBC(i,ivar,ng)%Chapman =ad_LBC(i,ivar,ng)%Chapman tl_LBC(i,ivar,ng)%clamped =ad_LBC(i,ivar,ng)%clamped tl_LBC(i,ivar,ng)%closed =ad_LBC(i,ivar,ng)%closed tl_LBC(i,ivar,ng)%Flather =ad_LBC(i,ivar,ng)%Flather tl_LBC(i,ivar,ng)%gradient =ad_LBC(i,ivar,ng)%gradient tl_LBC(i,ivar,ng)%nested =ad_LBC(i,ivar,ng)%nested tl_LBC(i,ivar,ng)%nudging =ad_LBC(i,ivar,ng)%nudging tl_LBC(i,ivar,ng)%periodic =ad_LBC(i,ivar,ng)%periodic tl_LBC(i,ivar,ng)%radiation=ad_LBC(i,ivar,ng)%radiation tl_LBC(i,ivar,ng)%reduced =ad_LBC(i,ivar,ng)%reduced END DO END DO #endif
Many thanks to Ha Joon Song for reporting this bug.
I also updated the makefile configuration file Darwin-ifort.mk to avoid warning errors from newer versions of the ifort compiler:
We need to have: FFLAGS := -heap-arrays -fp-model source instead of FFLAGS := -heap-arrays -fp-model precise
for Fortran compiling. The precise argument is redundant.
Note:
See TracTickets
for help on using tickets.