Opened 13 years ago
Closed 13 years ago
#560 closed bug (Fixed)
Bug in NEMURO, if HOLLING_GRAZING is activated
| Reported by: | kate | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.6 |
| Component: | Nonlinear | Version: | 3.6 |
| Keywords: | Cc: |
Description (last modified by )
There is a bug in the NEMURO model for the grazing of small zooplankton when the option HOLLING_GRAZING is activated. At line 670 of nemuro.h there is a ** where there should be a *:
!
! Predactory Zooplankton grazing on Small Zooplankton, GraZS2ZP.
!
#if defined IVLEV_EXPLICIT
cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo)))
cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
GraZS2ZP=fac6*cff3*cff5*MAX(0.0_r8,cff4)*Bio(i,k,iPzoo)
Bio(i,k,iSzoo)=Bio(i,k,iSzoo)-GraZS2ZP
Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP
#else
# ifdef HOLLING_GRAZING
cff4=1.0_r8/(KZS2ZP(ng)+Bio(i,k,iSzoo)*Bio(i,k,iSzoo))
cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
!> wrong cff=fac6*cff3**cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
cff=fac6*cff3*cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
# elif defined IVLEV_IMPLICIT
cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo)))
cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
cff6=1.0_r8/(fac6*cff4)
cff=(1.0_r8+Bio(i,k,iSzoo)*cff6)*cff3*cff5*Bio(i,k,iPzoo)
# endif
Bio(i,k,iSzoo)=Bio(i,k,iSzoo)/(1.0_r8+cff)
GraZS2ZP=cff*Bio(i,k,iSzoo)
Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP
#endif
Many thanks to Chris Edwards for bringing this to our attention.
Change History (1)
comment:1 by , 13 years ago
| Description: | modified (diff) |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
| Summary: | Bug in NEMURO → Bug in NEMURO, if HOLLING_GRAZING is activated |
Note:
See TracTickets
for help on using tickets.
