Opened 12 years ago

Closed 12 years ago

#556 closed defect (Fixed)

falling off end of Cval in decode_line

Reported by: kate Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.6
Component: Nonlinear Version: 3.6
Keywords: Cc:

Description (last modified by arango)

I've got a biological model with more than 25 tracers. The reading of LBC fails after the 25th with Nval getting larger than 100, since Nval is four times the tracer number (four values per tracer). There's a Cval array dimensioned 100 in decode_line. I can change that to 200 in decode_line, but then I'll have to track down that 100 up the chain...

Change History (1)

comment:1 by arango, 12 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed
Type: bugdefect

Indeed, there is a problem here if we have a model with more than 25 additional tracers. None of the models that we distribute have that many tracers except EcoSim. However, we do not expect any application that requires different boundary conditions for each of EcoSim passive tracers. In this case, we use the compact specification for LBC. For example, for East-West periodic application, we will have:

!                   W       S       E       N
!                   e       o       a       o
!                   s       u       s       r
!                   t       t       t       t
!                           h               h
!
!                   1       2       3       4

   LBC(isTvar) ==   Per     Clo     Per     Clo      ! idbio(:), compact

ROMS will internally assigns the same boundary conditions for all passive tracer since we just specified a single line in the standard input script.

I followed your recommendation and I increased the value of Cval to 200.

Note: See TracTickets for help on using tickets.