#529 closed bug (Fixed)
Corrected a bug on convolve.F
Reported by: | arango | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Adjoint Based Algorithms |
Component: | Adjoint | Version: | 3.6 |
Keywords: | Cc: |
Description (last modified by )
Removed the initialization of the flag LwrtTime around line 460 of convolve.F:
IF (Nrec(ng).gt.3) THEN LwrtTime(ng)=.TRUE. DO irec=1,Nrec(ng)-1 ... END DO END IF
This forced ad_wrt_his.F to over-write the ocean_time in the NetCDF file with the incorrect values. All values are the same for all records since ForceTime(ng) is always the same ad the initialization time (last one processed). This also affected the impulse time management in TLF NetCDF file in weak constraint applications for 4D-PSAS and R4D-Var.
The LwrtTime switch needs to be FALSE when convolving all the record in the adjoint history file.
Many thanks to Andy Moore and Emilie Neveu for bringing this to my attention.
Change History (3)
comment:1 by , 13 years ago
Description: | modified (diff) |
---|---|
Resolution: | → Fixed |
Status: | new → closed |
comment:2 by , 13 years ago
Description: | modified (diff) |
---|
comment:3 by , 12 years ago
Milestone: | Release ROMS/TOMS 3.6 → Adjoint Based Algorithms |
---|
Note:
See TracTickets
for help on using tickets.