Opened 14 years ago
Closed 14 years ago
#526 closed bug (Fixed)
Missing T_PASSIVE
Reported by: | arango | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.6 |
Component: | Nonlinear | Version: | 3.6 |
Keywords: | Cc: |
Description
The T_PASSIVE conditional is missing in get_data.F and set_data.F whe processing surface and bottom inert tracers fluxes. If there is not net surface or bottom flux for these tracers, the code it is still correct since stflx and btflx is initialized to zero when the array are allocated. We need to have the following logic when processing such fields:
# if defined BIOLOGY || defined SEDIMENT || defined T_PASSIVE ... # endif
The TLM, RPM, ADM version of these files are also corrected. Many thanks to Lyon Lanerolle for reporting this problem.
I also corrected the units attribute in output NetCDF files for Wsed, tau_ce, and tau_cd. We need to have instead:
double Wsed(NST) ; Wsed:long_name = "sediment particle settling velocity" ; Wsed:units = "meter second-1" ; double tau_ce(NST) ; tau_ce:long_name = "sediment critical shear for erosion" ; tau_ce:units = "meter-2 second-2" ; double tau_cd(NST) ; tau_cd:long_name = "sediment critical shear for deposition" ; tau_cd:units = "meter-2 second-2" ;
Many thanks to Changwei Bian for bringing this to my attention.