Opened 13 years ago

Closed 13 years ago

#508 closed bug (Fixed)

Assignment of SCRATCH_DIR in the main Makefile out of place

Reported by: colucix Owned by: arango
Priority: trivial Milestone: Release ROMS/TOMS 3.5
Component: Nonlinear Version: 3.5
Keywords: makefile Cc:

Description (last modified by arango)

I'd like to report a minor bug in the latest revision 554. At the beginning of the main makefile, has been added the assignment

  libraries  := $(SCRATCH_DIR)/libUTIL.a

but the SCRATCH_DIR environment variable is assigned afterward, after the end of the user-defined section. We should move the assignment of SCRATCH_DIR at the beginning, to avoid an error at compilation time, e.g.

make: *** No rule to make target `/libUTIL.a', needed by `oceanM'.  Stop

where is obvious that the value $(SCRATCH_DIR) is still null.

Change History (1)

comment:1 by arango, 13 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed

Yes, good catch. I didn't discover this one because I always use the build script. I highly recommend to everybody to use the build (build.bash or build.sh) script. This environmental variable need to be initialized after the SCRATCH_DIR is initialized.

I also corrected a tiny bug in adsen_ocean.h. Many thanks to Ha Joon Song for bringing this to my attention.

Note: See TracTickets for help on using tickets.