Opened 7 years ago

Closed 7 years ago

#505 closed bug (Fixed)

Vorticity Calculation in vorticity.F

Reported by: cmoffat Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.5
Component: Nonlinear Version: 3.5
Keywords: vorticity.F Cc:

Description (last modified by arango)

Hello,

I was very glad to see vorticity added to average file output. However, I believe there are a few issues with the way it is being calculated:

  • The last term for pvor (vorticity.F, line 378) should read -dVdz_pr * dRdx_pr (instead of -dVdz_pr * dRde_pr)
  • It looks like relative vorticity, rvor, is being treated as a scalar, so that all three components are added together. Shouldn't this either be the magnitude of the relative vorticity, or just its vertical component (the first term)?
  • I believe there's an extra d(pden)/d(z) in the preamble of the code, where the expressions for pvor and rvor are.

I might be missing something, of course. I've attached a diff file in case it is useful.

Best Regards, Carlos

Attachments (1)

vorticity.patch (1.5 KB) - added by cmoffat 7 years ago.
Diff File

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by cmoffat

Diff File

comment:1 Changed 7 years ago by arango

  • Description modified (diff)
  • Resolution set to Fixed
  • Status changed from new to closed

Yes, you are correct! Good catch... The relative vorticity is a vector since it is the curl of velocity (Grad X V) which gives a vector. I intended to have the vertical component of relative vorticity and not the magnitude. The vertical component is more insightful. It also give us the direction (sign) of rotation.

Many thanks for reporting this...

Note: See TracTickets for help on using tickets.