Opened 15 years ago

Closed 15 years ago

#450 closed bug (Fixed)

Bug in set_avg.F and typo on wrt_tides

Reported by: ocecept Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.4
Component: Nonlinear Version: 3.4
Keywords: AVERAGE_DETIDE Cc:

Description (last modified by arango)

Lines 2233 and 2353 at set_avg.F 

2231 TIDES(ng)%vbar_tide(i,j,nk)=TIDES(ng)%vbar_tide(i,j,    & 
2232 &                                                 nk)+  &    
2233 &                           OCEAN(ng)%zeta(i,j,Kout)*   & 
2234 &                           tide_harmonics(nk) 


2351 TIDES(ng)%vbar_tide(i,j,nk)=TIDES(ng)%vbar_tide(i,j,    & 
2352 &                                               nk)+    & 
2353 &                           OCEAN(ng)%zeta(i,j,Kout)*   & 
235  &                           tide_harmonics(nk)

Should be replaced by: 

&                           OCEAN(ng)%vbar(i,j,Kout)*   &

This error was introduced on revision 462 and results in wrong values to vbar_detide when AVERAGE_DETIDE is used.

There is also a small typo on line 170 at wrt_tides.F 

      IF (Aout(idu3dD,ng)) THEN

that should be replaced by: 

       IF (Aout(idv2dD,ng)) THEN

Change History (1)

comment:1 by arango, 15 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Yes, great catch! This is a typical cut and paste bug. Thank you for reporting this problem.

Note: See TracTickets for help on using tickets.