Opened 15 years ago
Closed 15 years ago
#419 closed upgrade (Done)
Logic with the 256 characters file names
Reported by: | arango | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.4 |
Component: | Nonlinear | Version: | 3.4 |
Keywords: | Cc: |
Description
In src:ticket:418, I allowed for the file name to a maximum of 256 characters long. This requires a change in inp_par.F, function decode_line, to declare several strings as 256 characters long. I knew that I needed to make this change but I forgot.
This also affects the include file for biology (ecosim_inp.h, fennel_inp.h, nemuro_inp.h, npzd_Franks_inp.h, npzd_Powell_inp.h, npzd_iron_inp.h) and sediment (sediment_inp.h) models. ROMS developers of new biological models need to take notice of this change. For example, you need to have in any routine included in inp_par.F:
character (len=40) :: KeyWord character (len=256) :: line character (len=256), dimension(100) :: Cval
One of these days, I will include all these routines in inp_par.F inside a module. It is in my things-to-do list.
I am aware of many users being burn out because of the previous 80 character limit on file names. I think that 256 (a nice power of 2) is a decent length for any file, including URL from OPeNDAP.