Opened 15 years ago

Closed 15 years ago

#353 closed bug (Fixed)

Failure from wrt_stations.F when LdefSTA is false.

Reported by: kate Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.3
Component: Nonlinear Version: 3.3
Keywords: Cc:

Description (last modified by arango)

Turn off the processing of stations and floats if not running long enough to create such NetCDF files. That is, LdefSTA(ng) is false because nSTA(ng) < ntimes or nSTA(ng) = 0 when nrrec = 0. Therefore, we also need Lstations(ng) to be false.

The following patch to inp_par.F fix the problem:

diff --git a/ROMS/Utility/inp_par.F b/ROMS/Utility/inp_par.F
index dc13796..9a6fa88 100644
--- a/ROMS/Utility/inp_par.F
+++ b/ROMS/Utility/inp_par.F
@@ -11100,6 +11100,10 @@
 !  Report input parameters.
 !-----------------------------------------------------------------------
 !
+      DO ng=1,Ngrids
+        IF (.not. LdefFLT(ng) .and. Lfloats(ng))                        &
+     &                 Lfloats(ng) = .FALSE.
+      END DO
       IF (Lwrite) THEN
         DO ng=1,Ngrids
           IF (ncount(ng).ne.Nfloats(ng)) THEN
@@ -11534,6 +11538,10 @@
 !  Report input parameters.
 !-----------------------------------------------------------------------
 !
+      DO ng=1,Ngrids
+        IF (.not. LdefSTA(ng) .and. Lstations(ng))                      &
+     &                 Lstations(ng) = .FALSE.
+      END DO
       IF (Lwrite) THEN
         DO ng=1,Ngrids
           IF (Lstations(ng)) THEN

Change History (1)

comment:1 by arango, 15 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed
Summary: Failure from wrt_stations when LdefSTA is false.Failure from wrt_stations.F when LdefSTA is false.

Well, I cannot reproduce this problem. My versions of the code run fine in such circunstances. Anyway, I implemented this fix as a safeguard for now. I may come back to this issue in the future since I always like to get to the bottom of the problem.

I also fixed a bug reported by Ufuk Turuncoglu in the forum about a typo in esmf_roms.F when defining LBj and UBj.

Note: See TracTickets for help on using tickets.