Opened 16 years ago

Closed 16 years ago

#321 closed bug (Fixed)

Problem with Lfloats == F

Reported by: mathieu Owned by: arango
Priority: minor Milestone: Release ROMS/TOMS 3.3
Component: Nonlinear Version: 3.3
Keywords: Cc:

Description (last modified by arango)

This option is supposed to work like Lstations == F, i.e. we can compile with FLOATS or STATIONS and still deactivate them at runtime. But those options create segmentation faults when running. The solution is to modify the files inp_par.F, grid_coord.F and main3d.F by adding some tests there.

Attachments (1)

DIFF_grid_coord​ (6.3 KB ) - added by mathieu 16 years ago.

Download all attachments as: .zip

Change History (4)

by mathieu, 16 years ago

Attachment: DIFF_grid_coord​ added

comment:1 by arango, 16 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Yes, good catch. The Lfloats and Lstation switch is also missing the output.F. Actually, this is the important routine that controls the output.

comment:2 by m.hadfield, 16 years ago

Resolution: Fixed
Status: closed → reopened

The changes to grid_coords.F made in response to this ticket have introduced a bug when SOLVE3D is not defined.

The following lines (150-151) 

#  ifdef SOLVE3D
        IF (Lfloats(ng)) THEN

need to be swapped 

        IF (Lfloats(ng)) THEN
#  ifdef SOLVE3D

to avoid a dangling "END IF" at the end of the block.

comment:3 by arango, 16 years ago

Resolution: → Fixed
Status: reopened → closed
Note: See TracTickets for help on using tickets.