ana_psource.h problem

[m.hadfield]

When compiled with explicit-shape declarations, subroutine ana_psource_grid (file ROMS/Functionals/ana_psource.h, revision 48) contains

integer, intent(out)

Nsrc

and later there are several arguments dimensioned with this, eg:

logical, intent(out)

Lsrc(Nsrc,NT(ng))

integer, intent(out)

Isrc(Nsrc)

So Lsrc, Isrc, etc are dimensioned with an intent(out) argument, which is illegal and obviously problematic, as the compiler needs to knwo the dimensions before calling the subroutine. However Nsrc can't be made intent(in) as its value is specified inside the subroutine.

Arguments Lsrc, Isrc, etc need to be declared with the same dimensions as the actual arrays they correspond to, namely SOURCES(ng)%Lsrc, SOURCES(ng)%Isrc, etc. The dimensions are determined when they are allocated in subroutine allocate_sources, module mod_sources, the declarations above should be

logical, intent(out)

Lsrc(Msrc,NT(ng))

integer, intent(out)

Isrc(Msrc)

This value has to be fed to the subroutine somehow. I've done it with

#ifndef ASSUMED_SHAPE

USE mod_sources, ONLY : Msrc

#endif

but alternatively it could be fed in as an extra argument.

Corrected file is attached.

[m.hadfield]

Those explicit-shape declarations are a pain, aren't they?

[arango]

Yes, they are a pain. I think that you are about the only one using them. Anyway, it is good to resolve all these bugs.