Opened 17 years ago

Closed 17 years ago

#283 closed bug (Fixed)

ana_srflux diurnal flux factor is wrong in high latitude endless daylight case

Reported by: wilkin Owned by: arango
Priority: minor Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description (last modified by arango)

Line 215 of ana_srflux.h should be 

         cff=cff1

the factor of 2*pi is wrong.

The comment about it should read: 

!  Normalization = (1/2*pi) INTEGRAL{ABS(a+b*COS(t)) dt} from 0 to 2*pi
!                = (a*ARCCOS(-a/b)+SQRT(b**2-a**2))/pi   for |a|<|b|

Change History (1)

comment:1 by arango, 17 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Yes, thank you. Also many thanks to Kate for ​tracking this problem. The correction is: 

!  Normalization = (1/2*pi)*INTEGRAL{ABS(a+b*COS(t)) dt}  from 0 to 2*pi
!                = (a*ARCCOS(-a/b)+SQRT(b**2-a**2))/pi    for |a| < |b|
!
          IF (ABS(cff1).gt.ABS(cff2)) THEN
            IF (cff1*cff2.gt.0.0_r8) THEN
              cff=cff1                                 ! All day case
Note: See TracTickets for help on using tickets.