Opened 15 years ago

Closed 15 years ago

#265 closed bug (Fixed)

Few corrections to ticket src:ticket:263

Reported by: arango Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description

Corrected few bug to the major upgrade in src:ticket:263

  • Corrected ad_convolution.F at line 764: the END IF needs to be before the endif CPP token.
  • Corrected CPP directive in tl_convolution.F at line 755.
  • Corrected reporting of NLpenalty in w4dpsas_ocean.h.
  • Changed model flag from iRPM to iNLM in obs_cost.F during the computation of NLpenalty in the W4DPSAS algorithm.
  • Corrected the computation of minimum and maximum tile fractional coordinates used to process the observations. Added new routine get_domain in get_bounds.F to facilitate the computation of such values. Notice that different ranges are computed for FULL_GRID option wich includes interior and boundary points. Also, mod_ncparam.F was modified to compute such values. It still have activated the incorrect computation.
  • Fixed few problems in inp_par.F when reporting HdecayF. I Also removed the MPI reduction to the DOMAIN(ng) structure. It is not longer needed.
  • Corrected few typos in the internal documentation.

Many thanks to Gregoire Broquet for reporting some of these problems.

Change History (1)

comment:1 by arango, 15 years ago

Resolution: Fixed
Status: newclosed
Summary: Few corrections to ticket 263Few corrections to ticket src:ticket:263
Note: See TracTickets for help on using tickets.