Opened 18 years ago
Closed 18 years ago
#24 closed bug (Fixed)
BL_TEST case suffering from bit rot
Reported by: | m.hadfield | Owned by: | arango |
---|---|---|---|
Priority: | minor | Milestone: | Release ROMS/TOMS 3.1 |
Component: | Nonlinear | Version: | 3.1 |
Keywords: | Cc: |
Description (last modified by )
The BL_TEST case appears to lack some preprocessor macros that it needs. The macro ANA_WWAVE is defined, but there is a compiler error on the source in ana_wwave.h. See below.
Should this case be updated or deleted?
The error: in ana_wwave.h the following code is specified
#if defined BL_TEST wdir=210.0_r8*deg2rad DO j=JstrR,JendR DO i=IstrR,IendR Hwave(i,j)=0.5_r8 Dwave(i,j)=wdir Pwave(i,j)=8.0_r8 END DO END DO #elif ...
however Hwave is available only if WAVES_HEIGHT is defined (which it isn't), Dwave is available only if BBL_MODEL or NEARSHORE_MELLOR is defined (which they aren't), and Pwave appears to have been replaced by Pwave_top and Pwave_bot.
Change History (2)
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | new → closed |
We need to activate CPP option SG_CALC_UB in bl_test.h and nj_bight.h to resolve the problem with Hwave. The variable Pwave was renamed to Pwave_bot to diffentiate between bottom and surface forcing.
The formatting of Fortran source needs to be included with code block (fifth bottom menu) syntax.
Note that the funny formatting of Fortran source in the above has been generated by Trac.