Coefficients not initialised in step_floats.F

[m.hadfield]

In step_floats.F, the following code (lines 278-286)...

!
!  Compute vertical position (grid units) 3D Lagrangian floats.
!
          IF (Ftype(l).eq.flt_Lagran) THEN
            track(izgrd,nfp1,l)=cff1*track(izgrd,nf  ,l)-               &
     &                          cff2*track(izgrd,nfm2,l)+               &
     &                          dt(ng)*(cff3*track(izrhs,nfp1,l)+       &
     &                                  cff4*track(izrhs,nf  ,l)-       &
     &                                  cff3*track(izrhs,nfm1,l))

...uses coefficients cff1, cff2, cff3 and cff4. However cff3 and cff4 have not been initialised, and cff1 and cff2 have values 8/3 and 4/3 (assigned to them at lines 264-265) which don't look right in this expression.

The effect of the uninitialised values is platform-dependent: on a Cray T3E it causes the model to crash.

[m.hadfield]

PS: the new code with the uninitialised coefficients appears to have been introduced at revision 237, in response to ticket 209.

[arango]

Yes, good catch. I copied and pasted the wrong piece of code.