Opened 16 years ago

Closed 16 years ago

#151 closed bug (Invalid)

zero depth trouble

Reported by: kate Owned by: arango
Priority: minor Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description

With the wet-dry option, it is more likely that someone will attempt to run with a depth of zero somewhere in the grid. The model doesn't put up with that, even if it is inside the land mask. I'm attaching one option for a patch.

Attachments (1)

patch.h (924 bytes ) - added by kate 16 years ago.
patch

Download all attachments as: .zip

Change History (2)

by kate, 16 years ago

Attachment: patch.h added

patch

comment:1 by arango, 16 years ago

Resolution: Invalid
Status: newclosed

No, this is not a good idea!!! This fix will actually affect the results when there is a lot of beach erosion and will introduce another bug to the code. There is not need to do this because in set_depth there is logic to avoid dividing by zero depth:

# if defined WET_DRY
          IF (h(i,j).eq.0.0_r8) THEN
            h(i,j)=eps
          END IF
# endif

where eps = 1.0E-14_r8 (very small). Recall that this the only place in the code that we divide by depth. Notice that we also take the absolute value of h when taking the squred-root.

Note: See TracTickets for help on using tickets.