Opened 17 years ago

Closed 17 years ago

#104 closed bug (Fixed)

combo of LMD and WET_DRY blows up

Reported by: kate Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.1
Component: Nonlinear Version: 3.1
Keywords: Cc:

Description (last modified by arango)

Question about this code in step2d:

# if defined WET_DRY && defined MASKING
          zeta(i,j,knew)=zeta(i,j,knew)+                                &
     &                   (Dcrit(ng)-h(i,j))*(1.0_r8-rmask(i,j))
# endif

Do you really want to do this inside the land mask or just inside the rmask_wet? It causes trouble in the LMD_SKPP inside the land mask when h is big (say 312m). It leads to a wacky computation of the light at the bottom of the mixed layer if zeta=-312. If this is indeed correct, I would advocate setting h to hmin inside the land mask after it is read in.

Attachments (1)

kpp.patch (1.5 KB ) - added by kate 17 years ago.

Download all attachments as: .zip

Change History (3)

by kate, 17 years ago

Attachment: kpp.patch added

comment:2 by kate, 17 years ago

I attached a patch which is one solution for making things work with both WET_DRY and KPP.

comment:3 by arango, 17 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.