Opened 7 years ago

Closed 7 years ago

#773 closed bug (Fixed)

small stuff for gfortran and -fcheck=all — at Version 1

Reported by: kate Owned by:
Priority: minor Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description (last modified by arango)

While compiling with the gfortran compiler and the following flags: 

 -fcheck=all -fsanitize=address -fsanitize=undefined

we discovered few issues. The routines wclock_on and wclock_off need to be recursive.Also, LBC%reduced not initialized in mod_param.F.

The routines read_phypar.F and read_stapar.F were modified to suppress lots of warnings in gfortran: 

At line XXX of file read_phypar.f90
Fortran runtime warning: An array temporary was created

Change History (2)

by kate, 7 years ago

Attachment: gfortran_checking.diff​ added

patch file to fix issue

comment:1 by arango, 7 years ago

Description: modified (diff)
Resolution: → Fixed
Status: new → closed

Yes, thank you. I also fixed the issues with read_phypar.F and read_stapar.F. There is still an issue with the random number generator (routine ran_init), but there is nothing that we can do. It seems that gfortran doesn't support 32-bit integer under negation and wrap-around addition.

Note: See TracTickets for help on using tickets.