Changes between Initial Version and Version 1 of Ticket #677


Ignore:
Timestamp:
08/04/15 21:10:40 (10 years ago)
Author:
arango
Comment:

Yes, thank you for bringing this to my attention. I missed this forum message. I also corrected that tangent linear, representer, and adjoint versions of this routine.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #677

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #677 – Description

    initial v1  
    1 I'm following up on a forum post entitled 'POWELL without SPITZ CPP option' dated Nov 27 2013. This post discusses a bug that has gone unfixed as of January 14 2015 when I downloaded the version of ROMS I am currently working with.
     1I'm following up on a forum post entitled '''NPZD_POWELL''' without '''SPITZ''' CPP option dated Nov 27 2013. This [https://www.myroms.org/forum/viewtopic.php?f=19&t=3163 post] discusses a bug that has gone unfixed as of January 14 2015 when I downloaded the version of ROMS I am currently working with.
    22
    33To reiterate:
    44
    5 The option to run npzd_Powell without SPITZ flag produces an error in the phytoplankton growth rate. Perhaps make the SPITZ option activated by default as that follows Powell et al. 2006, delete the alternative code, and delete the SPITZ CPP option?
     5The option to run '''NPZD_POWELL''' without '''SPITZ''' flag produces an error in the phytoplankton growth rate. Perhaps make the '''SPITZ''' option activated by default as that follows Powell ''et al''. 2006, delete the alternative code, and delete the '''SPITZ''' CPP option?
    66
    7 For example, in npzd_Powell.h
     7For example, in '''npzd_Powell.h''' replace the following:
    88
    9 replace the following:
    109
     10{{{
    1111#ifdef SPITZ
    1212          cff1=dtdays*Vm_NO3(ng)*PhyIS(ng)
    … …  
    3535
    3636
     37}}}
     38
    3739with:
    3840
     41
     42{{{
    3943          cff1=dtdays*Vm_NO3(ng)*PhyIS(ng)
    4044          cff2=Vm_NO3(ng)*Vm_NO3(ng)
    … …  
    5155            END DO
    5256          END DO
     57}}}