Opened 10 years ago
Closed 10 years ago
#664 closed bug (Fixed)
Bug in get_3dfldr.F — at Version 1
Reported by: | austinctodd | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
Component: | Adjoint | Version: | 3.7 |
Keywords: | Cc: |
Description (last modified by )
There is a sign error in get_3dfldr.F where it checks if data that has a cycle_length needs to be read. Lines 149-154 say the following:
IF (Liocycle) THEN Trec=MOD(Trec,Nrec)-1 IF (Trec.le.0) Trec=Nrec-Trec ELSE Trec=Trec-1 END IF
The issue is with
Trec=Nrec-Trec
, which makes Trec greater than nrec instead of cycling the integer. It should actually be Trec=Nrec+Trec
to be consistent with get_2dfldr.F'
Change History (1)
comment:1 by , 10 years ago
Description: | modified (diff) |
---|---|
Resolution: | → Fixed |
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Yes, good catch. The routines get_2dfldr.F and get_3dfldr.F are only used in the adjoint model and we have never used cycle_length in the input NetCDF files for such applications.