diagnostics bug

[jcwarner]

Not sure why this was not seen before. But most likely because the idiag index was not exceeded. There is a bug in step3d_uv.F, line 937 needs to be in an idiag loop the code now has:

# if defined DIAGNOSTICS_UV && defined MASKING
          DO k=1,N(ng)
            DO i=Istr,Iend
              DiaV3wrk(i,j,k,idiag)=DiaV3wrk(i,j,k,idiag)*vmask(i,j)
            END DO
          END DO
# endif

but it really needs to be:

# if defined DIAGNOSTICS_UV && defined MASKING
          DO k=1,N(ng)
            DO i=Istr,Iend
              DO idiag=1,NDM3d
                DiaV3wrk(i,j,k,idiag)=DiaV3wrk(i,j,k,idiag)*vmask(i,j)
              END DO
            END DO
          END DO
# endif

[arango]

Yes, thank you for reporting this one. The impact of this bug is very minimal since the state variables were already masked. However, it is good to correct this. I can believe that the compilers didn't pick-up this one.