Changes between Initial Version and Version 1 of Ticket #560


Ignore:
Timestamp:
06/25/12 18:53:37 (12 years ago)
Author:
arango
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #560

    • Property Resolution → Fixed
    • Property Status new → closed
    • Property Summary Bug in NEMURO → Bug in NEMURO, if HOLLING_GRAZING is activated

  • Ticket #560 – Description

    initial v1  
    1 This was reported by Chris Edwards. There is a '**' where there should be a '*':
     1There is a bug in the '''NEMURO''' model for the grazing of small zooplankton when the option '''HOLLING_GRAZING''' is activated. At line 670 of '''nemuro.h''' there is a '''!**''' where there should be a '''*''':
     2{{{
     3!
     4!  Predactory Zooplankton grazing on Small Zooplankton, GraZS2ZP.
     5!
     6#if defined IVLEV_EXPLICIT
     7              cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo)))
     8              cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
     9              GraZS2ZP=fac6*cff3*cff5*MAX(0.0_r8,cff4)*Bio(i,k,iPzoo)
     10              Bio(i,k,iSzoo)=Bio(i,k,iSzoo)-GraZS2ZP
     11              Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP
     12#else
     13# ifdef HOLLING_GRAZING
     14              cff4=1.0_r8/(KZS2ZP(ng)+Bio(i,k,iSzoo)*Bio(i,k,iSzoo))
     15              cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
     16!> wrong      cff=fac6*cff3**cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
     17              cff=fac6*cff3*cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
     18# elif defined IVLEV_IMPLICIT
     19              cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo)))
     20              cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
     21              cff6=1.0_r8/(fac6*cff4)
     22              cff=(1.0_r8+Bio(i,k,iSzoo)*cff6)*cff3*cff5*Bio(i,k,iPzoo)
     23# endif
     24              Bio(i,k,iSzoo)=Bio(i,k,iSzoo)/(1.0_r8+cff)
     25              GraZS2ZP=cff*Bio(i,k,iSzoo)
     26              Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP
     27#endif
     28}}}
    229
    3 diff --git a/ROMS/Nonlinear/Biology/nemuro.h b/ROMS/Nonlinear/Biology/nemuro.
    4 h
    5 index 7dcff70..6a7f193 100644
    6 --- a/ROMS/Nonlinear/Biology/nemuro.h
    7 +++ b/ROMS/Nonlinear/Biology/nemuro.h
    8 @@ -670,7 +670,7 @@
    9  # ifdef HOLLING_GRAZING
    10                cff4=1.0_r8/(KZS2ZP(ng)+Bio(i,k,iSzoo)*Bio(i,k,iSzoo))
    11                cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
    12 -              cff=fac6*cff3**cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
    13 +              cff=fac6*cff3*cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo)
    14  # elif defined IVLEV_IMPLICIT
    15                cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo)))
    16                cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo))
     30Many thanks to Chris Edwards for bringing this to our attention.