Opened 16 years ago

Last modified 16 years ago

#313 closed bug

WET_DRY problem for Vstretching=2,3 in set_scoord.F — at Initial Version

Reported by: rsignell Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.3
Component: Nonlinear Version: 3.3
Keywords: Cc:

Description

If WET_DRY is defined and Vstretching 2 or 3 is used, ROMS will quit with an error message if there it topography above the level of the free-surface (which is generally the case in WET_DRY applications).

There are two problems:

  1. Looking at set_scoord.F, I see that the following lines only occur

in the Vstreching == 1 case:

# if defined WET_DRY
       hc(ng)=MIN(MAX(hmin(ng),0.0_r8),Tcline(ng))
# else
       hc(ng)=MIN(hmin(ng),Tcline(ng))
# endif

This code should be executed before the check of which stretching function was used so that it applies to all stretching functions.

  1. In the Vstretching=2,3 sections of the code, these lines:

       hc(ng)=Tcline(ng)
       IF (hc(ng).le.hmin(ng)) THEN
        ELSE

and

          WRITE (stdout,10) hc(ng), hmin(ng)
          exit_flag=5
        END IF

should be removed, as in the Vstretching = 1 case.

My modified set_scoord.F is attached.

Change History (1)

by rsignell, 16 years ago

Attachment: set_scoord.F added

set_scoord.F that works with WET_DRY and Vstretching==2 or 3

Note: See TracTickets for help on using tickets.