Opened 17 years ago
Closed 17 years ago
#153 closed bug (Fixed)
small typos/bugs — at Version 1
| Reported by: | jacopo | Owned by: | arango |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release ROMS/TOMS 3.2 |
| Component: | Nonlinear | Version: | 3.2 |
| Keywords: | Cc: |
Description (last modified by )
in mod_coupler.F, there are 2 missing "&" for line continuation: line 364 and 373
in mpdata_adiff.F, the same: line 421 and 633.
Logical variable VECTOR in swanpre1.F gets screwed up during compilation.
Jacopo & Sandro
Change History (1)
comment:1 by , 17 years ago
| Description: | modified (diff) |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Yes, good catch. The problem that you are having with swanpre1.F is because you have a CPP option named VECTOR in cppdefs.h. I compiled and ran the coupled models with IFORT and I don't see the problem that you are reporting. I suspect that your application CPP option is VECTOR.
There are several uppercase words that cannot be used as CPP options in ROMS. This includes all the structures of ROMS like OCEAN, GRID, BOUNDARY and so on. The SWAN model is all in uppercase. This is an old legacy code and it is not recommended nowadays to use uppercase code. The CPP options by traditions are all uppercase. Recall that during C-preprocessing all the definitions are set to 1 when activated.