Changes between Initial Version and Version 1 of Ticket #813


Ignore:
Timestamp:
05/16/19 01:55:50 (6 years ago)
Author:
arango
Comment:

Oops, Indeed. I missed that one. I guess that I cut and paste the definition of size2d in several modules. The memory report is just a diagnostic but is good to have an accurate estimate.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #813

    • Property Priority major → minor
    • Property Resolution → Fixed
    • Property Status new → closed
    • Property Summary size2d too small → Memory Usage Underestimated in Report

  • Ticket #813 – Description

    initial v1  
    1 It seems to me that size2d needs to be bigger, here and elsewhere:
     1The dynamic and automatic memory usage is underestimated in the standard output report because of the local variable '''size2d''' needs to be bigger in several modules.
    22
    33{{{
    4 diff --git a/ROMS/Modules/mod_coupling.F b/ROMS/Modules/mod_coupling.F
    5 index b8124ec..03cdce3 100644
    6 --- a/ROMS/Modules/mod_coupling.F
    7 +++ b/ROMS/Modules/mod_coupling.F
    8 @@ -122,7 +122,7 @@
    9  !
    10  !  Set horizontal array size.
    11  !
    12 -      size2d=REAL((UBi-LBi)*(UBj-LBj),r8)
    13 +      size2d=REAL((UBi-LBi+1)*(UBj-LBj+1),r8)
    14  !
    15  !  Nonlinear model state.
    16  !
     4We need to have:
     5
     6       size2d=REAL((UBi-LBi+1)*(UBj-LBj+1),r8)
     7
     8instead of
     9     
     10       size2d=REAL((UBi-LBi)*(UBj-LBj),r8)
    1711}}}
     12for the horizontal array size.
     13