id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
742	Faulty proprocessor logic for DIAGNOSTICS_BIO	m.hadfield		"In ROMS/Include/globaldefs.h at lines 765-768 the effect of the following lines...
{{{
#if (!defined BIO_FENNEL  && defined DIAGNOSTICS_BIO) || \
    (!defined HYPOXIA_SRM && defined DIAGNOSTICS_BIO)
#  undef DIAGNOSTICS_BIO
#endif
}}}
...is to undefine '''DIAGNOSTICS_BIO''' unless both '''BIO_FENNEL''' and '''HYPOXIA_SRM''' are defined.

I suggest...
{{{
#if defined DIAGNOSTICS_BIO && !(defined BIO_FENNEL || HYPOXIA_SRM)
#  undef DIAGNOSTICS_BIO
#endif
}}}
...or its syllogistic equivalent.

----

Oops, the '''defined''' is missing before '''HYPOXIA_SRM'''.  We need to have instead:
 {{{
#if defined DIAGNOSTICS_BIO && \
  !(defined BIO_FENNEL      || defined HYPOXIA_SRM)
#  undef DIAGNOSTICS_BIO
#endif
}}}


"	bug	closed	major	Release ROMS/TOMS 3.7	Nonlinear	3.7	Fixed