Changes between Initial Version and Version 1 of Ticket #665


Ignore:
Timestamp:
06/23/15 20:22:26 (10 years ago)
Author:
arango
Comment:

Yes, indeed. Good catch correcting this factor in the diagnostic terms. Also thank you for cleaning the code a little.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #665

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #665 – Description

    initial v1  
    11Attached is a lightly modified version of fennel.h with the following improvements, mostly minor, but a significant bug fix:
    22
    3 1. Added implicit none
     31. Added '''implicit none'''.
    44
    5 2. Simplified declaration of u10squ
     52. Simplified declaration of '''u10squ'''.
    66
    7 3. Simplified treatment of N & C remineralisation fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)
     73. Simplified treatment of N & C remineralization fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)
    88
    9 4. The bug fix: defined a factor fiter = 1/BioIter(ng), applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when BioIter(ng) exceeds 1. I have checked this one out pretty thoroughly
     94. The '''bug fix''': defined a factor '''fiter = 1/!BioIter(ng)''', applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when '''!BioIter(ng''') exceeds '''1'''. I have checked this one out pretty thoroughly!