typo in cppdefs.h

Bug reports, work arounds and fixes

Moderators: arango, robertson

Post Reply
Message
Author
Barbara
Posts: 25
Joined: Thu Sep 14, 2006 4:33 pm
Location: LTO, SCSIO

typo in cppdefs.h

#1 Unread post by Barbara »

The "SMAGORINSKI" in cppdefs.h should be changed into "SMAGORINSKY" as those in other codes. Otherwise this option won't be activated. :idea:

marceloandrioni
Posts: 4
Joined: Wed Mar 26, 2008 7:15 pm
Location: ----

#2 Unread post by marceloandrioni »

I downloaded the code one month ago and my version didn't have the typo (I checked whith grep). Are you sure someone else didn't change your cppdefs.h?

User avatar
arango
Site Admin
Posts: 1350
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:

#3 Unread post by arango »

Yes, I corrected this typo yesterday in svn revision 177. I also corrected ticket 149.

I do not recommend to use TS_SMAGORISNKY because there is not a physical way to relate horizontal viscosity to horizontal diffusion. In the past, people just computed the Smagorisnky diffusion from the viscosity. This is done in ROMS for didactic purposes, as mentioned in :arrow: ticket 149..

Post Reply