Bug in nesting when MASKING not defined

Bug reports, work arounds and fixes

Moderators: arango, robertson

Post Reply
Message
Author
jpringle
Posts: 107
Joined: Sun Jul 27, 2003 6:49 pm
Location: UNH, USA

Bug in nesting when MASKING not defined

#1 Unread post by jpringle »

In the latest ROMS, the model does not compile when NESTING is defined but MASKING is not. The error is minor; mask_hweights is always defined at the top of nesting.F even when MASKING is on. The fix is straightforward:

Code: Select all

*** nesting.F_old	2015-08-18 10:49:28.000000000 -0400
--- nesting.F	2015-08-18 10:40:01.000000000 -0400
***************
*** 119,125 ****
--- 119,127 ----
        PRIVATE :: get_metrics
        PRIVATE :: get_persisted2d
        PRIVATE :: get_refine
+ # ifdef MASKING
        PRIVATE :: mask_hweights
+ # endif
        PRIVATE :: put_composite
        PRIVATE :: put_refine
        PRIVATE :: put_refine2d
Cheers,
Jamie

User avatar
arango
Site Admin
Posts: 1347
Joined: Wed Feb 26, 2003 4:41 pm
Location: DMCS, Rutgers University
Contact:

Re: Bug in nesting when MASKING not defined

#2 Unread post by arango »

Yep, good catch. Thank yTo be precise we need instead:

Code: Select all

# if defined MASKING || defined WET_DRY
      PRIVATE :: mask_hweights
# endif
I will update the code today.

Post Reply